[jaeger] Add extraVolumes/extraVolumeMounts to deployment#738
Draft
maynardflies wants to merge 1 commit intojaegertracing:mainfrom
Draft
[jaeger] Add extraVolumes/extraVolumeMounts to deployment#738maynardflies wants to merge 1 commit intojaegertracing:mainfrom
maynardflies wants to merge 1 commit intojaegertracing:mainfrom
Conversation
The v4.2.0 chart rewrite removed the ability to mount custom volumes on the Jaeger deployment, which is needed for storage backends like Badger that require local persistent volumes. This adds extraVolumes and extraVolumeMounts fields to the jaeger values section, following the same pattern already used by the spark, esIndexCleaner, esRollover, and esLookback job templates. Fixes jaegertracing#737 Signed-off-by: Greg Olmstead <greg@nubelo.io>
|
Hi! Thanks for working on this. I’m also looking forward to this change for my project. Do you have an estimate on when it might be ready? Let me know if there's anything I can help with! |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You may re-open it if you need more time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extraVolumesandextraVolumeMountsfields to thejaegerdeployment values, restoring the ability to mount custom volumes (PVCs, secrets, configmaps, etc.) on the Jaeger podspark,esIndexCleaner,esRollover, andesLookbackjob templatesFixes #737
Test plan
helm lint charts/jaegerpasseshelm templaterenders correctly with default values (no extra volumes)helm templaterenders correctly with extra volumes/mounts set (PVC and mountPath appear in output)